Open
Conversation
pacu
force-pushed
the
zebra-4-support
branch
2 times, most recently
from
ee646de to
22817c0
Compare
Contributor
Author
|
I'm having inconclusive regressions. I'm going to re-run the test on current dev and zebra 4.1 |
pacu
force-pushed
the
zebra-4-support
branch
from
22817c0 to
07b7b89
Compare
Contributor
Author
|
Latest run all zebra tests pass |
Contributor
Author
|
I have ran all tests and all the zebra tests pass (a bunch of zcashd related timeout but those are probably related to the tests being slow) |
Contributor
|
we have been experiencing differences in results between CI and local testing. have you given the testsuite a run locally? if so, are you managing binaries manually or using "makers container-test"? the latest option is the only one that seems to be reliably passing all tests for us recently. |
Contributor
|
For CI to run against zebra 4.1.0 the file |
pacu
force-pushed
the
zebra-4-support
branch
from
07b7b89 to
8d025f5
Compare
AloeareV
reviewed
Feb 19, 2026
Comment on lines
+15
to
+19
| /// | ||
| /// 1. Detect a payment to your Shielded address | ||
| /// 1. Detect a spend of your Shielded notes | ||
| /// 1. Update your witnesses to generate new spend proofs. | ||
| /// 1. Spend UTXOs associated to t-addresses of your wallet. |
Contributor
There was a problem hiding this comment.
This change was procedurally generated from a proto file. The compact_formats.proto file still contains the numbers 1. 2. 3. 4. For some reason, proto is now generating 1. 1. 1. 1. This isn't a blocking concern (as it's purely a procedurally-generated comment), but I must admit I am absolutely baffled.
Contributor
Author
There was a problem hiding this comment.
oh I think MD actually solves the count when rendering.
pacu
force-pushed
the
zebra-4-support
branch
from
93c2dcd to
69fd392
Compare
Added CHANGELOG entries and documentation on how to perform this kind of updates update .env.testing-artifacts closes zingolabs#816
Adds sleep statement to allow wallet to sync before `quick_shield`
pacu
force-pushed
the
zebra-4-support
branch
from
d8fd938 to
4dcdf06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #816